CDCFlowWorkflowState: remove Progress, Statuses, Errors #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these should be logged instead of put in state, this avoids queries failing to due to size being too large Since normalize/sync flows handle their logging, reduce signalling too
serprex
force-pushed
the
reduce-query-result-size
branch
from
15d470b to
b3c712c
Compare
iskakaushik
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these should be logged instead of put in state, this avoids queries failing to due to size being too large
Since normalize/sync flows handle their logging, reduce signalling too
SyncFlowStatuses was being checked by dynamic signals test to test exact batch numbering.
Be looser: testing that data is being replicated properly is sufficient